BUG: Fix CMake options scikit-build-core on macOS and Linux#275
Merged
thewtex merged 2 commits intoInsightSoftwareConsortium:masterfrom May 30, 2024
Merged
BUG: Fix CMake options scikit-build-core on macOS and Linux#275thewtex merged 2 commits intoInsightSoftwareConsortium:masterfrom
thewtex merged 2 commits intoInsightSoftwareConsortium:masterfrom
Conversation
dzenanz
approved these changes
May 29, 2024
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
LGTM, but some better versed in bash should review too.
Author
|
I have a bug on Windows (see here, the string is not adequately handled) so you may want to wait the patch before merging |
Author
No sorry, the problem is not in ITKPythonPackage I believe, this PR can be merged. |
thewtex
approved these changes
May 30, 2024
thewtex
added a commit
to thewtex/ITKRemoteModuleBuildTestPackageAction
that referenced
this pull request
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is propagating to MacOS and Linux what's in Windows:
https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/master/scripts/windows_build_module_wheels.py#L99
The Linux version has been tested in https://github.com/RTKConsortium/ITKCudaCommon/actions/runs/9275896116/job/25521657471. I haven't tested MacOS' version.